[Don't merge][WIP][Prototype] Add Python instrumentation Labeler #3689
+483
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't merge please / WIP / Prototype
Adds new a Python instrumentation Labeler, inspired by Go's
net/http
instrumentation: open-telemetry/opentelemetry-go-contrib#306. It stores KVs added to it in the current context. Theadd
/add_attributes
can be called by user's instrumented code manually, or by custom distros.Labeler could be read by existing instrumentors so that any added KVs are merged into the attributes of metrics being written. In this PR,
FlaskInstrumentor
does this so that custom attributes are added to therecord
calls of the new and old duration histograms.Could address #3405 though with a new class instead of request/response hooks.
Provides foundation for ASGI instrumentor custom metrics, #1801
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.